From 1f44aafa41174e7e8442179c526ed313d09e0bda Mon Sep 17 00:00:00 2001 From: Onur Gündüz Date: Tue, 29 Sep 2026 14:36:40 +0200 Subject: Correct CLI information flags and reject unknown long options --- tests/cli_tests.rs | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) (limited to 'tests') diff --git a/tests/cli_tests.rs b/tests/cli_tests.rs index c283e19..c195c5c 100644 --- a/tests/cli_tests.rs +++ b/tests/cli_tests.rs @@ -153,6 +153,43 @@ fn empty_filter_and_print_mode() { assert_eq!(output.stdout, std::fs::read(path).unwrap()); } +#[test] +fn information_flags_succeed_and_unknown_long_options_fail() { + for flag in ["--help", "-h", "--version", "-V"] { + let output = Command::new(env!("CARGO_BIN_EXE_aip-filter")) + .arg(flag) + .stdin(Stdio::null()) + .output() + .unwrap(); + assert_eq!(output.status.code(), Some(0), "{flag}"); + assert!(output.stderr.is_empty()); + let text = String::from_utf8(output.stdout).unwrap(); + if matches!(flag, "--help" | "-h") { + assert!(text.contains("usage:")); + assert!(text.contains("--max-record-bytes")); + assert!(text.contains("--version")); + } else { + assert_eq!(text, format!("aip-filter {}\n", env!("CARGO_PKG_VERSION"))); + } + } + for flag in ["--verison", "--unknown", "--print=invalid"] { + let output = Command::new(env!("CARGO_BIN_EXE_aip-filter")) + .arg(flag) + .stdin(Stdio::null()) + .output() + .unwrap(); + assert_eq!(output.status.code(), Some(2), "{flag}"); + assert!(output.stdout.is_empty()); + assert!(String::from_utf8_lossy(&output.stderr).contains("unknown option")); + } + let output = run("-- literal comment", "raw input\n", &["--"]); + assert!(output.status.success()); + assert_eq!(output.stdout, b"raw input\n"); + let output = run("-p", "\"unrelated\"\n", &["--"]); + assert!(output.status.success()); + assert_eq!(output.stdout, b"\"unrelated\"\n"); +} + #[test] fn invalid_json_is_reported_and_returns_failure() { let output = run("foobar", "not json\n{\"msg\":\"foobar\"}\n", &[]); @@ -305,4 +342,16 @@ fn output_flush_errors_are_reported() { .write_all(b"{\"msg\":\"foobar\"}\n") .unwrap(); assert!(!child.wait_with_output().unwrap().status.success()); + for flag in ["--help", "--version"] { + let (writer, reader) = UnixStream::pair().unwrap(); + drop(reader); + let output = Command::new(env!("CARGO_BIN_EXE_aip-filter")) + .arg(flag) + .stdin(Stdio::null()) + .stdout(Stdio::from(OwnedFd::from(writer))) + .stderr(Stdio::piped()) + .output() + .unwrap(); + assert_eq!(output.status.code(), Some(1)); + } } -- cgit v1.3.1