From 48d6191f4701fe7d059f1a298907beeba7e680bc Mon Sep 17 00:00:00 2001 From: Onur Gündüz Date: Wed, 17 Jun 2026 00:42:10 +0200 Subject: api: guard cosine similarity denominator against overflow --- src/vec.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) (limited to 'src/vec.c') diff --git a/src/vec.c b/src/vec.c index 63bd4bc..cea1576 100644 --- a/src/vec.c +++ b/src/vec.c @@ -35,12 +35,19 @@ float embed_cosine_similarity(const float *a, const float *b, int dim) { float norm_a_sq = 0.0f; float norm_b_sq = 0.0f; for (int i = 0; i < dim; i++) { - dot += a[i] * b[i]; - norm_a_sq += a[i] * a[i]; - norm_b_sq += b[i] * b[i]; + float av = a[i]; + float bv = b[i]; + dot += av * bv; + norm_a_sq += av * av; + norm_b_sq += bv * bv; } - if (!(norm_a_sq > 0.0f) || !(norm_b_sq > 0.0f) || !isfinite(norm_a_sq) || !isfinite(norm_b_sq)) + if (!(norm_a_sq > 0.0f) || !(norm_b_sq > 0.0f) || !isfinite(norm_a_sq) || + !isfinite(norm_b_sq) || !isfinite(dot)) return 0.0f; - return dot / sqrtf(norm_a_sq * norm_b_sq); + + double denom = sqrt((double)norm_a_sq) * sqrt((double)norm_b_sq); + if (!(denom > 0.0) || !isfinite(denom)) + return 0.0f; + return (float)((double)dot / denom); } -- cgit v1.3.1