diff options
| author | Onur Gündüz <ogunduz@gmail.com> | 2026-06-17 00:40:50 +0200 |
|---|---|---|
| committer | Onur Gündüz <ogunduz@gmail.com> | 2026-06-17 00:40:50 +0200 |
| commit | d27b38730d6010abf1217f779f048778675c90c3 (patch) | |
| tree | 5e8d0e5c438241d87f099bc507b75c8106d68df7 | |
| parent | 00e5cd9beac815c981561ed66a823153abc62cd3 (diff) | |
| download | ffwd-d27b38730d6010abf1217f779f048778675c90c3.tar.gz ffwd-d27b38730d6010abf1217f779f048778675c90c3.zip | |
server: free prior response in job_set_422
| -rw-r--r-- | src/server_json.c | 1 | ||||
| -rw-r--r-- | tests/test_server.c | 22 |
2 files changed, 23 insertions, 0 deletions
diff --git a/src/server_json.c b/src/server_json.c index e84dd4b..e45c2c7 100644 --- a/src/server_json.c +++ b/src/server_json.c @@ -99,6 +99,7 @@ void job_set_422(job *j, cJSON *detail) { job_set_error(j, 500, "failed to render validation error", "server_error"); return; } + free(j->response); j->status = 422; j->content_type = "application/json"; j->response = xstrdup(s); diff --git a/tests/test_server.c b/tests/test_server.c index 6cc6e66..6a558ae 100644 --- a/tests/test_server.c +++ b/tests/test_server.c @@ -99,6 +99,27 @@ static void test_json_error_body_escaping(void) { free(body); } +static void test_job_set_422_replaces_response(void) { + job j; + memset(&j, 0, sizeof(j)); + j.response = xstrdup("old response"); + j.response_len = strlen(j.response); + j.status = 500; + + cJSON *detail = cJSON_CreateArray(); + ve_add(detail, "[\"body\",\"field\"]", "bad value", "value_error"); + job_set_422(&j, detail); + TEST_ASSERT(j.status == 422); + TEST_ASSERT(j.response != NULL); + if (j.response) { + TEST_ASSERT(j.response_len == strlen(j.response)); + TEST_ASSERT(strstr(j.response, "bad value") != NULL); + } + + cJSON_Delete(detail); + free(j.response); +} + static void test_quantize_int8_tanh(void) { TEST_ASSERT(quantize_int8_tanh(0.0f) == 0); /* tanh saturates to +-1, scaled by 127. */ @@ -1106,6 +1127,7 @@ int main(void) { test_base64_rfc4648(); test_sbuf_growth_and_formatting(); test_json_error_body_escaping(); + test_job_set_422_replaces_response(); test_quantize_int8_tanh(); test_encode_embedding_int8(); test_encode_embedding_binary(); |
