aboutsummaryrefslogtreecommitdiff
path: root/embed.c
diff options
context:
space:
mode:
authorOnur Gündüz <ogunduz@gmail.com>2026-06-14 16:06:18 +0200
committerOnur Gündüz <ogunduz@gmail.com>2026-06-14 16:41:53 +0200
commitcb1f049e710cf8704ae29811b3058142c7f64840 (patch)
tree85df308a574fbc3408cd88cd82471896337c8669 /embed.c
parentbb41b40bf881a1c59ee0d6153bcb0bb2f7a0044b (diff)
downloadffwd-cb1f049e710cf8704ae29811b3058142c7f64840.tar.gz
ffwd-cb1f049e710cf8704ae29811b3058142c7f64840.zip
all: add Qwen3-Embedding-4B + fix terminal token
Diffstat (limited to 'embed.c')
-rw-r--r--embed.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/embed.c b/embed.c
index 9feb99c..bd72846 100644
--- a/embed.c
+++ b/embed.c
@@ -239,14 +239,12 @@ static int parse_config(embed_config_t *cfg, const char *model_dir)
cfg->pooling_mode = EMBED_POOL_MEAN;
cfg->normalize_embeddings = 0;
cfg->append_terminal_token = 0;
- cfg->terminal_token_id = -1;
if (json_string_equals(buf, "model_type", "qwen3")) {
cfg->attention_mode = EMBED_ATTENTION_CAUSAL;
cfg->pooling_mode = EMBED_POOL_LAST_TOKEN;
cfg->normalize_embeddings = 1;
cfg->append_terminal_token = 1;
- cfg->terminal_token_id = json_get_int(buf, "eos_token_id", -1);
}
cfg->q_dim = 0;
@@ -267,10 +265,7 @@ static int parse_config(embed_config_t *cfg, const char *model_dir)
cfg->vocab_size <= 0 || cfg->q_dim <= 0 || cfg->kv_dim <= 0 ||
(cfg->head_dim & 1) || cfg->n_heads % cfg->n_kv_heads != 0 ||
!isfinite(cfg->rms_norm_eps) || cfg->rms_norm_eps <= 0.0f ||
- !isfinite(cfg->rope_theta) || cfg->rope_theta <= 0.0f ||
- (cfg->append_terminal_token &&
- (cfg->terminal_token_id < 0 ||
- cfg->terminal_token_id >= cfg->vocab_size))) {
+ !isfinite(cfg->rope_theta) || cfg->rope_theta <= 0.0f) {
fprintf(stderr, "embed_model_load: invalid config in %s "
"(hidden=%d, layers=%d, heads=%d/%d, head_dim=%d, inter=%d)\n",
path, cfg->hidden_size, cfg->n_layers, cfg->n_heads,