diff options
| author | Onur Gündüz <ogunduz@gmail.com> | 2026-06-14 16:06:18 +0200 |
|---|---|---|
| committer | Onur Gündüz <ogunduz@gmail.com> | 2026-06-14 16:41:53 +0200 |
| commit | cb1f049e710cf8704ae29811b3058142c7f64840 (patch) | |
| tree | 85df308a574fbc3408cd88cd82471896337c8669 /embed_mlx.c | |
| parent | bb41b40bf881a1c59ee0d6153bcb0bb2f7a0044b (diff) | |
| download | ffwd-cb1f049e710cf8704ae29811b3058142c7f64840.tar.gz ffwd-cb1f049e710cf8704ae29811b3058142c7f64840.zip | |
all: add Qwen3-Embedding-4B + fix terminal token
Diffstat (limited to 'embed_mlx.c')
| -rw-r--r-- | embed_mlx.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/embed_mlx.c b/embed_mlx.c index cbdfa33..cb3b737 100644 --- a/embed_mlx.c +++ b/embed_mlx.c @@ -408,14 +408,11 @@ static int mlx_parse_config(embed_config_t *cfg, const char *model_dir) cfg->pooling_mode = EMBED_POOL_MEAN; cfg->normalize_embeddings = 0; cfg->append_terminal_token = 0; - cfg->terminal_token_id = -1; if (json_string_equals_m(buf, "model_type", "qwen3")) { - const char *eos = json_find_m(buf, "eos_token_id"); cfg->attention_mode = EMBED_ATTENTION_CAUSAL; cfg->pooling_mode = EMBED_POOL_LAST_TOKEN; cfg->normalize_embeddings = 1; cfg->append_terminal_token = 1; - cfg->terminal_token_id = eos ? atoi(eos) : -1; } cfg->q_dim = 0; @@ -434,10 +431,7 @@ static int mlx_parse_config(embed_config_t *cfg, const char *model_dir) cfg->vocab_size <= 0 || cfg->q_dim <= 0 || cfg->kv_dim <= 0 || (cfg->head_dim & 1) || cfg->n_heads % cfg->n_kv_heads != 0 || !isfinite(cfg->rms_norm_eps) || cfg->rms_norm_eps <= 0.0f || - !isfinite(cfg->rope_theta) || cfg->rope_theta <= 0.0f || - (cfg->append_terminal_token && - (cfg->terminal_token_id < 0 || - cfg->terminal_token_id >= cfg->vocab_size))) { + !isfinite(cfg->rope_theta) || cfg->rope_theta <= 0.0f) { fprintf(stderr, "mlx: invalid config in %s " "(hidden=%d, layers=%d, heads=%d/%d, head_dim=%d, inter=%d)\n", path, cfg->hidden_size, cfg->n_layers, cfg->n_heads, |
