aboutsummaryrefslogtreecommitdiff
path: root/pplx_embed.c
diff options
context:
space:
mode:
authorOnur Gündüz <ogunduz@gmail.com>2026-05-27 03:32:43 +0200
committerOnur Gündüz <ogunduz@gmail.com>2026-06-14 08:18:59 +0200
commitc4c730e6b0b68703fadb8758db014f511e1e123f (patch)
tree6ca606e914ab340f6804d8c2aad0421a6ceb2130 /pplx_embed.c
parent594324fc44ca62682cac930477abdf3dce94da69 (diff)
downloadffwd-c4c730e6b0b68703fadb8758db014f511e1e123f.tar.gz
ffwd-c4c730e6b0b68703fadb8758db014f511e1e123f.zip
cpu: keep batch offsets in workspace
Diffstat (limited to 'pplx_embed.c')
-rw-r--r--pplx_embed.c48
1 files changed, 38 insertions, 10 deletions
diff --git a/pplx_embed.c b/pplx_embed.c
index 32ea1e2..9260433 100644
--- a/pplx_embed.c
+++ b/pplx_embed.c
@@ -52,6 +52,9 @@ struct pplx_workspace {
float *ffn_gate; /* [seq, intermediate] */
float *ffn_up; /* [seq, intermediate] */
+ int *offsets; /* [batch + 1] packed sequence offsets */
+ int offsets_cap;
+
/* RoPE cosine/sine cache [n_pos, head_dim], grown lazily. */
float *rope_cos;
float *rope_sin;
@@ -137,6 +140,17 @@ static int realloc_floats_2d(float **ptr, int rows, int cols)
return realloc_floats(ptr, count);
}
+static int realloc_ints(int **ptr, size_t count)
+{
+ size_t bytes;
+ if (mul_size(count, sizeof(int), &bytes) != 0) return -1;
+
+ void *p = realloc(*ptr, bytes);
+ if (!p && bytes != 0) return -1;
+ *ptr = (int *)p;
+ return 0;
+}
+
/* ========================================================================
* Minimal JSON helpers for config.json parsing
* ======================================================================== */
@@ -525,6 +539,19 @@ static int ensure_rope_cache(pplx_workspace_t *ws, const pplx_config_t *cfg,
return 0;
}
+static int ensure_offsets(pplx_workspace_t *ws, int batch)
+{
+ if (!ws || batch <= 0 || batch == INT_MAX) return -1;
+
+ int needed = batch + 1;
+ if (needed <= ws->offsets_cap) return 0;
+
+ if (realloc_ints(&ws->offsets, (size_t)needed) != 0)
+ return -1;
+ ws->offsets_cap = needed;
+ return 0;
+}
+
/* ========================================================================
* Model / workspace load and free
* ======================================================================== */
@@ -665,6 +692,7 @@ void pplx_workspace_free(pplx_workspace_t *ws)
free(ws->q); free(ws->k); free(ws->v);
free(ws->attn_out); free(ws->proj_out);
free(ws->ffn_gate); free(ws->ffn_up);
+ free(ws->offsets);
free(ws->rope_cos); free(ws->rope_sin);
free(ws);
}
@@ -722,6 +750,13 @@ size_t pplx_workspace_nbytes(const pplx_workspace_t *ws)
add_size(total, bytes, &total) != 0)
return SIZE_MAX;
+ size_t offset_bytes = 0;
+ if (ws->offsets_cap > 0 &&
+ mul_size((size_t)ws->offsets_cap, sizeof(int), &offset_bytes) != 0)
+ return SIZE_MAX;
+ if (add_size(total, offset_bytes, &total) != 0)
+ return SIZE_MAX;
+
return total;
}
@@ -950,26 +985,19 @@ int pplx_model_embed_batch(const pplx_model_t *model, pplx_workspace_t *ws,
{
if (!model || !ws || !inputs || batch <= 0 || !out_embeddings) return -1;
- if (batch == INT_MAX) return -1;
- size_t offset_bytes;
- if (mul_size((size_t)batch + 1, sizeof(int), &offset_bytes) != 0)
- return -1;
- int *offsets = (int *)malloc(offset_bytes);
- if (!offsets) return -1;
+ if (ensure_offsets(ws, batch) != 0) return -1;
+ int *offsets = ws->offsets;
int total_seq = 0;
int max_seq = 0;
- if (build_offsets(inputs, batch, offsets, &total_seq, &max_seq) != 0) {
- free(offsets);
+ if (build_offsets(inputs, batch, offsets, &total_seq, &max_seq) != 0)
return -1;
- }
int rc = forward_packed_inplace(model, ws, inputs, batch, offsets,
total_seq, max_seq, 0);
if (rc == 0)
pool_normalized_embeddings(model, ws, offsets, batch, out_embeddings);
- free(offsets);
return rc;
}