1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
|
package fragment_test
import (
"bytes"
"encoding/binary"
"io"
"os"
"reflect"
"testing"
"git.onurgunduz.com/mp4"
"git.onurgunduz.com/mp4/fragment"
)
const testFile = "../test-data/big-buck-bunny-480p-30sec.mp4"
const audioTestFile = "../test-data/aac-10s.mp4"
func openTestFile(t testing.TB) *os.File {
t.Helper()
f, err := os.Open(testFile)
if err != nil {
t.Skipf("test file not available: %v", err)
}
return f
}
func TestNewReader(t *testing.T) {
f := openTestFile(t)
defer f.Close()
_, initSeg, err := fragment.NewReader(f)
if err != nil {
t.Fatal(err)
}
if len(initSeg.Tracks) != 2 {
t.Fatalf("expected 2 tracks, got %d", len(initSeg.Tracks))
}
vt := initSeg.VideoTrack()
if vt == nil {
t.Fatal("no video track")
}
if vt.Codec() != "avc1.64001e" {
t.Errorf("video codec = %q, want avc1.64001e", vt.Codec())
}
if vt.Width != 854 || vt.Height != 480 {
t.Errorf("video size = %dx%d, want 854x480", vt.Width, vt.Height)
}
if vt.TimeScale != 12288 {
t.Errorf("video timescale = %d, want 12288", vt.TimeScale)
}
at := initSeg.AudioTrack()
if at == nil {
t.Fatal("no audio track")
}
if at.Codec() != "mp4a.40.2" {
t.Errorf("audio codec = %q, want mp4a.40.2", at.Codec())
}
if at.SampleRate != 48000 {
t.Errorf("audio sample rate = %d, want 48000", at.SampleRate)
}
buf := initSeg.Bytes()
if len(buf) < 8 {
t.Fatal("init segment too small")
}
mr := mp4.NewReader(buf)
if !mr.Next() {
t.Fatal("expected ftyp in init segment")
}
if mr.Type() != mp4.TypeFtyp {
t.Errorf("first box = %s, want ftyp", mr.Type())
}
if !mr.Next() {
t.Fatal("expected moov in init segment")
}
if mr.Type() != mp4.TypeMoov {
t.Errorf("second box = %s, want moov", mr.Type())
}
}
func TestReadFragments(t *testing.T) {
f := openTestFile(t)
defer f.Close()
frag, initSeg, err := fragment.NewReader(f)
if err != nil {
t.Fatal(err)
}
fragCount := 0
totalSamples := 0
for {
fr, err := frag.ReadFragment()
if err == io.EOF {
break
}
if err != nil {
t.Fatal(err)
}
fragCount++
totalSamples += len(fr.Samples)
}
if fragCount == 0 {
t.Fatal("expected at least one fragment")
}
vt := initSeg.VideoTrack()
if totalSamples < len(vt.Samples) {
t.Errorf("total samples = %d, want at least %d (video samples)", totalSamples, len(vt.Samples))
}
t.Logf("fragments=%d totalSamples=%d", fragCount, totalSamples)
}
func TestReadAudioOnlyFragments(t *testing.T) {
f, err := os.Open(audioTestFile)
if err != nil {
t.Skipf("test file not available: %v", err)
}
defer f.Close()
r, init, err := fragment.NewReader(f)
if err != nil {
t.Fatal(err)
}
if init.VideoTrack() != nil || init.AudioTrack() == nil {
t.Fatalf("audio-only tracks = %+v", init.Tracks)
}
if err := r.SetTargetDuration(3); err != nil {
t.Fatal(err)
}
if err := r.Seek(4); err != nil {
t.Fatal(err)
}
fr, err := r.ReadFragment()
if err != nil {
t.Fatal(err)
}
vs, ve := r.VideoRun()
as, ae := r.AudioRun()
if vs != 0 || ve != 0 || as <= 0 || ae <= as || len(fr.Samples) != ae-as {
t.Fatalf("video=[%d,%d) audio=[%d,%d) samples=%d", vs, ve, as, ae, len(fr.Samples))
}
}
// movieTimescale returns the mvhd timescale from an ftyp+moov or bare moov buffer.
func movieTimescale(tb testing.TB, buf []byte) uint32 {
tb.Helper()
r := mp4.NewReader(buf)
for r.Next() {
if r.Type() != mp4.TypeMoov {
continue
}
r.Enter()
for r.Next() {
if r.Type() == mp4.TypeMvhd {
ts, _, _ := r.ReadMvhd()
return ts
}
}
r.Exit()
}
tb.Fatal("mvhd not found")
return 0
}
// TestInitSegmentCarriesSourceMovieTimescale overwrites the source movie
// timescale with a distinctive value and checks the init segment's mvhd reports
// it, proving the timescale comes from the source rather than a fixed constant.
func TestInitSegmentCarriesSourceMovieTimescale(t *testing.T) {
data, err := os.ReadFile(testFile)
if err != nil {
t.Skipf("test file not available: %v", err)
}
// The version-0 mvhd timescale sits after the 4-byte creation and
// modification times in the box data.
const wantTS = 90000
patched := false
r := mp4.NewReader(data)
for r.Next() && !patched {
if r.Type() != mp4.TypeMoov {
continue
}
r.Enter()
for r.Next() {
if r.Type() == mp4.TypeMvhd {
if r.Version() != 0 {
t.Skip("mvhd is not version 0")
}
off := r.DataOffset()
binary.BigEndian.PutUint32(data[off+8:off+12], wantTS)
patched = true
break
}
}
r.Exit()
}
if !patched {
t.Fatal("mvhd not found in source")
}
tmp, err := os.CreateTemp(t.TempDir(), "patched-*.mp4")
if err != nil {
t.Fatal(err)
}
if _, err := tmp.Write(data); err != nil {
t.Fatal(err)
}
if _, err := tmp.Seek(0, io.SeekStart); err != nil {
t.Fatal(err)
}
_, initSeg, err := fragment.NewReader(tmp)
if err != nil {
t.Fatal(err)
}
if got := movieTimescale(t, initSeg.Bytes()); got != wantTS {
t.Errorf("init movie timescale = %d, want %d", got, wantTS)
}
}
const keyframesEverySecondFile = "../test-data/h264-aac-10s-gop1.mp4"
// trunFlagsForTrack walks a moof+mdat buffer and returns the tr_flags of the
// trun in the traf whose tfhd names trackID.
func trunFlagsForTrack(buf []byte, trackID uint32) (uint32, bool) {
r := mp4.NewReader(buf)
for r.Next() {
if r.Type() != mp4.TypeMoof {
continue
}
r.Enter()
for r.Next() {
if r.Type() != mp4.TypeTraf {
continue
}
r.Enter()
var tid, flags uint32
var haveTrun bool
for r.Next() {
switch r.Type() {
case mp4.TypeTfhd:
tid = r.ReadTfhd()
case mp4.TypeTrun:
flags = r.Flags()
haveTrun = true
}
}
r.Exit()
if haveTrun && tid == trackID {
return flags, true
}
}
r.Exit()
}
return 0, false
}
// videoTrunFlags packages the first fragment of path at the given target
// duration and returns the video track's trun tr_flags.
func videoTrunFlags(t *testing.T, path string, targetSec float64) uint32 {
t.Helper()
f, err := os.Open(path)
if err != nil {
t.Skipf("test file not available: %v", err)
}
defer f.Close()
frag, initSeg, err := fragment.NewReader(f)
if err != nil {
t.Fatal(err)
}
if err := frag.SetTargetDuration(targetSec); err != nil {
t.Fatal(err)
}
vt := initSeg.VideoTrack()
if vt == nil {
t.Fatal("no video track")
}
fr, err := frag.ReadFragment()
if err != nil {
t.Fatal(err)
}
var buf bytes.Buffer
w := fragment.NewWriter(&buf)
if err := w.WriteInit(initSeg); err != nil {
t.Fatal(err)
}
if err := w.WriteFragment(fr, f); err != nil {
t.Fatal(err)
}
flags, ok := trunFlagsForTrack(buf.Bytes(), vt.ID)
if !ok {
t.Fatal("video trun not found in fragment")
}
return flags
}
// TestWriterSampleFlagsAdaptive locks the choice between per-sample trun flags
// and the compact first-sample-flags entry. A segment that spans several
// keyframes must carry per-sample flags; a segment holding only its leading
// keyframe must use the first-sample-flags form.
func TestWriterSampleFlagsAdaptive(t *testing.T) {
// One segment over the whole keyframe-every-second file holds many interior
// keyframes, so sync flags vary sample to sample and must be per-sample.
interior := videoTrunFlags(t, keyframesEverySecondFile, 3600)
if interior&mp4.TrunSampleFlagsPresent == 0 {
t.Errorf("interior-keyframe segment: tr_flags=%#06x, want TrunSampleFlagsPresent set", interior)
}
if interior&mp4.TrunFirstSampleFlagsPresent != 0 {
t.Errorf("interior-keyframe segment: tr_flags=%#06x, TrunFirstSampleFlagsPresent must not be set", interior)
}
// The first segment of a file whose next keyframe is far away holds a single
// keyframe, so only the first sample differs and the compact form is used.
single := videoTrunFlags(t, testFile, 1)
if single&mp4.TrunFirstSampleFlagsPresent == 0 {
t.Errorf("single-keyframe segment: tr_flags=%#06x, want TrunFirstSampleFlagsPresent set", single)
}
if single&mp4.TrunSampleFlagsPresent != 0 {
t.Errorf("single-keyframe segment: tr_flags=%#06x, TrunSampleFlagsPresent must not be set", single)
}
}
func TestWriteFragment(t *testing.T) {
f := openTestFile(t)
defer f.Close()
frag, initSeg, err := fragment.NewReader(f)
if err != nil {
t.Fatal(err)
}
if err := frag.SetTimeRange(5, 10); err != nil {
t.Fatal(err)
}
out, err := os.CreateTemp("", "fragment-test-*.mp4")
if err != nil {
t.Fatal(err)
}
defer os.Remove(out.Name())
defer out.Close()
w := fragment.NewWriter(out)
if err := w.WriteInit(initSeg); err != nil {
t.Fatal(err)
}
fragCount := 0
for {
fr, err := frag.ReadFragment()
if err == io.EOF {
break
}
if err != nil {
t.Fatal(err)
}
if err := w.WriteFragment(fr, f); err != nil {
t.Fatal(err)
}
fragCount++
}
if fragCount == 0 {
t.Fatal("expected at least one fragment")
}
out.Seek(0, io.SeekStart)
verifyOutputBoxes(t, out)
}
func TestSeek(t *testing.T) {
f := openTestFile(t)
defer f.Close()
frag, _, err := fragment.NewReader(f)
if err != nil {
t.Fatal(err)
}
frag1, err := frag.ReadFragment()
if err != nil {
t.Fatal(err)
}
frag1Len := len(frag1.Samples)
if err := frag.Seek(0); err != nil {
t.Fatal(err)
}
frag2, err := frag.ReadFragment()
if err != nil {
t.Fatal(err)
}
if len(frag2.Samples) != frag1Len {
t.Errorf("after seek, fragment has %d samples, want %d", len(frag2.Samples), frag1Len)
}
}
func TestReset(t *testing.T) {
f := openTestFile(t)
defer f.Close()
// A separate reader gives ground-truth samples from a fresh parse.
g := openTestFile(t)
defer g.Close()
_, fresh, err := fragment.NewReader(g)
if err != nil {
t.Fatal(err)
}
want := fresh.VideoTrack().Samples
r, _, err := fragment.NewReader(f)
if err != nil {
t.Fatal(err)
}
if _, err := f.Seek(0, io.SeekStart); err != nil {
t.Fatal(err)
}
init2, err := r.Reset(f)
if err != nil {
t.Fatal(err)
}
got := init2.VideoTrack().Samples
if !reflect.DeepEqual(got, want) {
t.Errorf("video samples after Reset differ from a fresh parse (got %d, want %d)", len(got), len(want))
}
fragCount := 0
for {
if _, err := r.ReadFragment(); err == io.EOF {
break
} else if err != nil {
t.Fatal(err)
}
fragCount++
}
if fragCount == 0 {
t.Fatal("no fragments after Reset")
}
}
func TestSetTimeRangeValidation(t *testing.T) {
f := openTestFile(t)
defer f.Close()
frag, _, err := fragment.NewReader(f)
if err != nil {
t.Fatal(err)
}
tests := []struct {
start, end float64
wantErr bool
}{
{0, 0, false}, // valid: entire file
{5, 10, false}, // valid: normal range
{0, 10, false}, // valid: from start
{-1, 10, true}, // invalid: negative start
{0, -1, true}, // invalid: negative end
{10, 5, true}, // invalid: end before start
{10, 10, true}, // invalid: zero-length range
}
for _, tt := range tests {
err := frag.SetTimeRange(tt.start, tt.end)
if (err != nil) != tt.wantErr {
t.Errorf("SetTimeRange(%v, %v): err=%v, wantErr=%v", tt.start, tt.end, err, tt.wantErr)
}
}
}
func verifyOutputBoxes(t *testing.T, f *os.File) {
t.Helper()
stat, _ := f.Stat()
data := make([]byte, stat.Size())
f.ReadAt(data, 0)
moofCount := 0
mdatCount := 0
hasFtyp := false
hasMoov := false
mr := mp4.NewReader(data)
for mr.Next() {
switch mr.Type() {
case mp4.TypeFtyp:
hasFtyp = true
case mp4.TypeMoov:
hasMoov = true
case mp4.TypeMoof:
moofCount++
mr.Enter()
trafCount := 0
for mr.Next() {
if mr.Type() == mp4.TypeTraf {
trafCount++
}
}
mr.Exit()
if trafCount == 0 {
t.Error("moof has no traf children")
}
case mp4.TypeMdat:
mdatCount++
}
}
if !hasFtyp {
t.Error("missing ftyp")
}
if !hasMoov {
t.Error("missing moov")
}
if moofCount == 0 {
t.Error("no moof boxes")
}
if mdatCount == 0 {
t.Error("no mdat boxes")
}
if moofCount != mdatCount {
t.Errorf("moof count (%d) != mdat count (%d)", moofCount, mdatCount)
}
t.Logf("output: ftyp=%v moov=%v moof=%d mdat=%d", hasFtyp, hasMoov, moofCount, mdatCount)
}
|